Repository navigation
Support Node 24 - #1497
Open
brandur wants to merge 1 commit into
Open
Support Node 24#1497brandur wants to merge 1 commit into
brandur wants to merge 1 commit into
Conversation
Got a request for this on X here [1]. Looking into it more, Node 24 is actually the "active" LTS today and recommended for production, It's going to be supported until 2028, so quite a bit of runway left. Here, implement support for Node 24. The main difference is that 24 doesn't have native Temporal, so we put in a polyfill here that's applied automatically, but not applied when Temporal is available. [1] https://x.com/Vince_Profeta/status/2109162057488548038 [2] https://nodejs.org/en/about/previous-releases
brandur
force-pushed
the
brandur-node-24
branch
from
October 11, 2026 08:51
a77d046 to
677c478
Compare
bgentry
approved these changes
Oct 11, 2026
bgentry
left a comment
bgentry
left a comment
Contributor
There was a problem hiding this comment.
Oh @vinceprofeta is a former colleague I briefly overlapped with at Royal 😄 
Comment on lines
+181
to
+182
| # Minimum and current releases for both supported Node lines. | ||
| node-version: ["24.0.0", "24", "26.0.0", ""] |
Contributor
There was a problem hiding this comment.
Should we pin to specific patch releases like this or do you think we should just stick with "24" and "26" to pull in the latest from each as we do in Go?
Comment on lines
-145
to
-147
| Node.js 26 or newer with native `Temporal`: `node -p "typeof Temporal"` must | ||
| print `object`. Official Node.js binaries include it; some builds compiled from | ||
| source, including some distribution and Homebrew packages, do not. |
Contributor
There was a problem hiding this comment.
Oops, I think this pulled in Node 26 originally as part of my push to use the temporal stuff for non-terrible datetime handling.
Comment on lines
+194
to
+198
| formatting, licenses, packed archives and examples. Unit tests run on Node | ||
| 24.0.0, 26.0.0, and the current releases of both lines. Packed packages run on | ||
| Node 24 and 26, including CommonJS consumers and TypeScript consumers with | ||
| `@types/node` 24. Integration tests cover Postgres 14 through 18 on Node 26 | ||
| and Postgres 18 on Node 24. |
Contributor
There was a problem hiding this comment.
Excessive detail in here IMO and likely to drift, no need to mention the exact releases we run unit tests against.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got a request for this on X here [1].
Looking into it more, Node 24 is actually the "active" LTS today and
recommended for production, It's going to be supported until 2028, so
quite a bit of runway left.
Here, implement support for Node 24. The main difference is that 24
doesn't have native Temporal, so we put in a polyfill here that's
applied automatically, but not applied when Temporal is available.
[1] https://x.com/Vince_Profeta/status/2109162057488548038
[2] https://nodejs.org/en/about/previous-releases